Below is a collection of conventions, guidlines and general tips for writing code for this project.
When adding new or modifying API types don’t expose 3rd party package types/enums via the CAPA API definitions. Instead create our own versions and where provide mapping functions.
- AWS SDK [InstaneState](https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/) - CAPA [InstanceState](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/api/v1beta1/types.go#L560:L581)
When adding new fields to an API type don’t use a slice of struct pointers. This can cause issues with the code generator for the conversion functions. Instead use struct slices.
Instead of this
// Configuration options for the non root storage volumes. // +optional NonRootVolumes *Volume `json:"nonRootVolumes,omitempty"`
// Configuration options for the non root storage volumes. // +optional NonRootVolumes Volume `json:"nonRootVolumes,omitempty"`
And then within the code you can check the length or range over the slice.
There are three types of tests written for CAPA controllers in this repo:
- Unit tests
- Integration tests
- E2E tests
If any new unit, integration or E2E tests has to be added in this repo,we should follow the below conventions.
These tests are meant to verify the functions inside the same controller file where we perform sanity checks, functionality checks etc. These tests go into the file with suffix *_unit_test.go.
These tests are meant to verify the overall flow of the reconcile calls in the controllers to test the flows for all the services/subcomponents of controllers as a whole. These tests go into the file with suffix *_test.go.
These tests are meant to verify the proper functioning of a CAPA cluster in an environment that resembles a real production environment. For details, refer here.